dialects: llvm.InLineAsmOp has_side_effects, is_align_stack are properties #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosseVanDelm
requested review from
superlopuh,
AntonLydike and
jorendumoulin
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3147 +/- ##
==========================================
- Coverage 89.99% 89.99% -0.01%
==========================================
Files 427 427
Lines 53854 53853 -1
Branches 8343 8343
==========================================
- Hits 48468 48467 -1
Misses 4038 4038
Partials 1348 1348 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apparently made a small yet significant error when I implemented this operation the first time, which sometimes gives weird errors in mixed pipelines.
has_side_effects,is_align_stackare optional properties defined as UnitAttributes.I apparently gave a very difficult to find error because I tested them as attributes, and not as properties. and because
has_side_effectsis not exactly the same ashas_side_effectI'm not sure the implementation I'm using here for defining optional properties is correct. It seems there are multiple ways of doing this in xdsl?